From fcece057c35783156100eaf6b868b5fb8fd3adda Mon Sep 17 00:00:00 2001 From: Steve Muckle Date: Sat, 18 Feb 2012 20:09:58 -0800 Subject: [PATCH] msm: pm: save registers to noncached area before pc The power collapse path is simplified if a noncached area is used for the purpose of saving register state prior to power collapsing. This is especially beneficial in the case of targets with an outer cache, where the process of cleaning the register state would require complex operations. Change-Id: I9edac28e4091548e2843fc87c89e3451df2b6ae9 Signed-off-by: Steve Muckle --- arch/arm/mach-msm/idle-v7.S | 39 ++++++++++++++++--------------------- arch/arm/mach-msm/idle.h | 14 ++++++++++++- arch/arm/mach-msm/pm-8x60.c | 11 +++++++++++ arch/arm/mach-msm/pm2.c | 11 +++++++++++ 4 files changed, 52 insertions(+), 23 deletions(-) diff --git a/arch/arm/mach-msm/idle-v7.S b/arch/arm/mach-msm/idle-v7.S index 868054d5af0..63ac78ee974 100644 --- a/arch/arm/mach-msm/idle-v7.S +++ b/arch/arm/mach-msm/idle-v7.S @@ -19,13 +19,8 @@ #include #include -#ifdef CONFIG_MSM_CPU_AVS -/* 11 general purpose registers (r4-r14), 10 cp15 registers, 3 AVS registers */ -#define CPU_SAVED_STATE_SIZE (4 * 11 + 4 * 10 + 4 * 3) -#else -/* 11 general purpose registers (r4-r14), 10 cp15 registers */ -#define CPU_SAVED_STATE_SIZE (4 * 11 + 4 * 10) -#endif +#include "idle.h" + #ifdef CONFIG_ARCH_MSM_KRAIT #define SCM_SVC_BOOT 0x1 #define SCM_CMD_TERMINATE_PC 0x2 @@ -45,7 +40,8 @@ ENTRY(msm_pm_collapse) cpsid f #endif - ldr r0, =saved_state + ldr r0, =msm_saved_state /* address of msm_saved_state ptr */ + ldr r0, [r0] /* load ptr */ #if (NR_CPUS >= 2) mrc p15, 0, r1, c0, c0, 5 /* MPIDR */ ands r1, r1, #15 /* What CPU am I */ @@ -100,14 +96,7 @@ ENTRY(msm_pm_collapse) cmp r1, #1 bne skip bl v7_flush_dcache_all - b skip2 - -skip: ldr r0, =saved_state - ldr r1, =saved_state_end - sub r1, r1, r0 - bl v7_flush_kern_dcache_area - -skip2: +skip: #ifdef CONFIG_ARCH_MSM_KRAIT ldr r0, =SCM_SVC_BOOT ldr r1, =SCM_CMD_TERMINATE_PC @@ -134,7 +123,8 @@ skip2: #ifdef CONFIG_MSM_JTAG bl msm_jtag_restore_state #endif - ldr r0, =saved_state /* restore registers */ + ldr r0, =msm_saved_state /* address of msm_saved_state ptr */ + ldr r0, [r0] /* load ptr */ #if (NR_CPUS >= 2) mrc p15, 0, r1, c0, c0, 5 /* MPIDR */ ands r1, r1, #15 /* What CPU am I */ @@ -143,7 +133,7 @@ skip2: add r0, r0, r2 #endif - ldmfd r0, {r4-r14} + ldmfd r0, {r4-r14} /* restore registers */ mov r0, #0 /* return power collapse failed */ bx lr @@ -157,11 +147,12 @@ ENTRY(msm_pm_collapse_exit) mov r1, #'A' str r1, [r0, #0x00C] #endif - ldr r1, =saved_state + ldr r1, =msm_saved_state_phys ldr r2, =msm_pm_collapse_exit adr r3, msm_pm_collapse_exit add r1, r1, r3 sub r1, r1, r2 + ldr r1, [r1] add r1, r1, #CPU_SAVED_STATE_SIZE #if (NR_CPUS >= 2) mrc p15, 0, r2, c0, c0, 5 /* MPIDR */ @@ -277,9 +268,13 @@ ENTRY(msm_pm_set_l2_flush_flag) msm_pm_pc_pgd: .long 0x0 -saved_state: - .space CPU_SAVED_STATE_SIZE * NR_CPUS -saved_state_end: + .globl msm_saved_state +msm_saved_state: + .long 0x0 + + .globl msm_saved_state_phys +msm_saved_state_phys: + .long 0x0 msm_pm_boot_vector: .space 4 * NR_CPUS diff --git a/arch/arm/mach-msm/idle.h b/arch/arm/mach-msm/idle.h index 6311b3ceaba..f8f6b3cf77b 100644 --- a/arch/arm/mach-msm/idle.h +++ b/arch/arm/mach-msm/idle.h @@ -14,9 +14,21 @@ #ifndef _ARCH_ARM_MACH_MSM_IDLE_H_ #define _ARCH_ARM_MACH_MSM_IDLE_H_ +#ifdef CONFIG_MSM_CPU_AVS +/* 11 general purpose registers (r4-r14), 10 cp15 registers, 3 AVS registers */ +#define CPU_SAVED_STATE_SIZE (4 * 11 + 4 * 10 + 4 * 3) +#else +/* 11 general purpose registers (r4-r14), 10 cp15 registers */ +#define CPU_SAVED_STATE_SIZE (4 * 11 + 4 * 10) +#endif + +#ifndef __ASSEMBLY__ + int msm_arch_idle(void); int msm_pm_collapse(void); void msm_pm_collapse_exit(void); +extern void *msm_saved_state; +extern unsigned long msm_saved_state_phys; #ifdef CONFIG_CPU_V7 void msm_pm_boot_entry(void); @@ -38,5 +50,5 @@ static inline void msm_pm_write_boot_vector(unsigned int cpu, /* empty */ } #endif - +#endif #endif diff --git a/arch/arm/mach-msm/pm-8x60.c b/arch/arm/mach-msm/pm-8x60.c index 9257f2f1d5a..5274e8b5b97 100644 --- a/arch/arm/mach-msm/pm-8x60.c +++ b/arch/arm/mach-msm/pm-8x60.c @@ -1182,6 +1182,17 @@ static int __init msm_pm_init(void) pmd[0] = __pmd(pmdval); pmd[1] = __pmd(pmdval + (1 << (PGDIR_SHIFT - 1))); + msm_saved_state_phys = + allocate_contiguous_ebi_nomap(CPU_SAVED_STATE_SIZE * + num_possible_cpus(), 4); + if (!msm_saved_state_phys) + return -ENOMEM; + msm_saved_state = ioremap_nocache(msm_saved_state_phys, + CPU_SAVED_STATE_SIZE * + num_possible_cpus()); + if (!msm_saved_state) + return -ENOMEM; + /* It is remotely possible that the code in msm_pm_collapse_exit() * which turns on the MMU with this mapping is in the * next even-numbered megabyte beyond the diff --git a/arch/arm/mach-msm/pm2.c b/arch/arm/mach-msm/pm2.c index 7903eabc039..58f2075aa8b 100644 --- a/arch/arm/mach-msm/pm2.c +++ b/arch/arm/mach-msm/pm2.c @@ -1879,6 +1879,17 @@ static int __init msm_pm_init(void) pmd[0] = __pmd(pmdval); pmd[1] = __pmd(pmdval + (1 << (PGDIR_SHIFT - 1))); + msm_saved_state_phys = + allocate_contiguous_ebi_nomap(CPU_SAVED_STATE_SIZE * + num_possible_cpus(), 4); + if (!msm_saved_state_phys) + return -ENOMEM; + msm_saved_state = ioremap_nocache(msm_saved_state_phys, + CPU_SAVED_STATE_SIZE * + num_possible_cpus()); + if (!msm_saved_state) + return -ENOMEM; + /* It is remotely possible that the code in msm_pm_collapse_exit() * which turns on the MMU with this mapping is in the * next even-numbered megabyte beyond the