From 9019555798a41ec0edbe4e85cda44922b9bedb54 Mon Sep 17 00:00:00 2001 From: Deepak Verma Date: Mon, 21 Oct 2013 17:37:11 +0530 Subject: [PATCH] msm: vidc: Check validity of userspace address Before writing to a userspace address, verification of the validity of user space address is required. Change-Id: I9141e44a6c11aaf3f4d57c08bb0dd26a7b214f34 CRs-fixed: 556356 Signed-off-by: Deepak Verma CVE-2014-9880 Signed-off-by: Kevin F. Haggerty --- drivers/video/msm/vidc/common/enc/venc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/msm/vidc/common/enc/venc.c b/drivers/video/msm/vidc/common/enc/venc.c index ee9c48b273b..c09f2bf748b 100755 --- a/drivers/video/msm/vidc/common/enc/venc.c +++ b/drivers/video/msm/vidc/common/enc/venc.c @@ -1422,6 +1422,12 @@ static long vid_enc_ioctl(struct file *file, return -EFAULT; DBG("VEN_IOCTL_GET_SEQUENCE_HDR\n"); + if (!access_ok(VERIFY_WRITE, seq_header.hdrbufptr, + seq_header.bufsize)) { + ERR("VEN_IOCTL_GET_SEQUENCE_HDR:"\ + " Userspace address verification failed.\n"); + return -EFAULT; + } result = vid_enc_get_sequence_header(client_ctx, &seq_header); if (!result) {