From 455904de99c362fe23758ba3ddfc3c8fb185d9b1 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 16 Jul 2014 09:37:04 +0300 Subject: [PATCH] ALSA: compress: fix an integer overflow check I previously added an integer overflow check here but looking at it now, it's still buggy. The bug happens in snd_compr_allocate_buffer(). We multiply ".fragments" and ".fragment_size" and that doesn't overflow but then we save it in an unsigned int so it truncates the high bits away and we allocate a smaller than expected size. Fixes: b35cc8225845 ('ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()') Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai CVE-2014-9904 Signed-off-by: Kevin F. Haggerty Change-Id: I04ed32d9c858ac971ff48235eed8f231ef39a277 --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index d84eca5a3ad..03d3fac17fa 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -487,7 +487,7 @@ static int snd_compress_check_input(struct snd_compr_params *params) { /* first let's check the buffer parameter's */ if (params->buffer.fragment_size == 0 || - params->buffer.fragments > UINT_MAX / params->buffer.fragment_size) + params->buffer.fragments > INT_MAX / params->buffer.fragment_size) return -EINVAL; /* now codec parameters */