From 0806438b5d11d41db6e38715597d72a7f5ddbe8a Mon Sep 17 00:00:00 2001 From: "Kevin F. Haggerty" Date: Fri, 4 Nov 2016 10:36:56 -0600 Subject: [PATCH] drivers: sensorhub: stm: Kill all the kmsg spam * You'd think that we could just disable CONFIG_SEC_DEBUG, but that just makes the Samsung kernel uncompileable. * Move around #defines in the ssp header file so that the right things are unguarded and the debug guard values are set to 0. * Verified that all sensors still work. Change-Id: If7101109571ac49c60c100f37ab334efcbaeccae Signed-off-by: Kevin F. Haggerty --- drivers/sensorhub/stm/ssp.h | 14 ++++++-------- drivers/sensorhub/stm/ssp_debug.c | 3 +-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/sensorhub/stm/ssp.h b/drivers/sensorhub/stm/ssp.h index 635e95311a1..4dc4f69565a 100644 --- a/drivers/sensorhub/stm/ssp.h +++ b/drivers/sensorhub/stm/ssp.h @@ -50,16 +50,17 @@ #include "ssp_sensorhub.h" #endif -#define SSP_DBG 1 -#ifdef CONFIG_SEC_DEBUG -#define SSP_SEC_DEBUG 1 -#else +#define SSP_DBG 0 +#define SSP_DATA_DBG 0 +#define SSP_FUNC_DBG 0 #define SSP_SEC_DEBUG 0 -#endif #define SUCCESS 1 #define FAIL 0 #define ERROR -1 +/* ssp mcu device ID */ +#define DEVICE_ID 0x55 + #define FACTORY_DATA_MAX 100 #undef SAVE_MAG_LOG/* Magnetic sensor data logging flag */ @@ -73,9 +74,6 @@ #define SSP_FUNC_DBG 1 #define SSP_DATA_DBG 0 -/* ssp mcu device ID */ -#define DEVICE_ID 0x55 - #define ssp_dbg(dev, format, ...) do { \ printk(KERN_INFO dev, format, ##__VA_ARGS__); \ diff --git a/drivers/sensorhub/stm/ssp_debug.c b/drivers/sensorhub/stm/ssp_debug.c index 194a3eb634e..ff2441be191 100644 --- a/drivers/sensorhub/stm/ssp_debug.c +++ b/drivers/sensorhub/stm/ssp_debug.c @@ -199,11 +199,10 @@ int print_mcu_debug(char *pchRcvDataFrame, int *pDataIdx, int iRcvDataFrameLength) { int iLength = pchRcvDataFrame[(*pDataIdx)++]; - int cur = *pDataIdx; if (iLength > iRcvDataFrameLength - *pDataIdx || iLength <= 0) { ssp_dbg("[SSP]: MSG From MCU - invalid debug length(%d/%d/%d)\n", - iLength, iRcvDataFrameLength, cur); + iLength, iRcvDataFrameLength, *pDataIdx); return iLength ? iLength : ERROR; }